Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdoc: improve vdocignore file handling by walking all .vdocignore sub-paths in IgnoreRules.get, add test #21521

Merged
merged 2 commits into from
May 18, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented May 17, 2024

With the changes, all ignore rules for a specified directory and its subdirectories are gathered first. This removes coupling with the process of getting modules and should simplify and improve testability. A test is also added.

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 755cdca into vlang:master May 18, 2024
24 checks passed
@ttytm ttytm deleted the vdoc/improve-ignore branch May 18, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants