Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builtin: simplify MessageError.msg() #21524

Merged
merged 3 commits into from
May 18, 2024
Merged

builtin: simplify MessageError.msg() #21524

merged 3 commits into from
May 18, 2024

Conversation

spytheman
Copy link
Member

@spytheman spytheman commented May 18, 2024 •
edited

  • builtin: let MessageError.msg() return only the message, make MessageError.str() return both the message and the code of an error
  • fix warning in vlib/vweb/tests/controller_duplicate_server.v
  • fix other test failures

The PR was motivated by https://discord.com/channels/592103645835821068/592320321995014154/1241174911486136372 .

@spytheman spytheman changed the title builtin simplify MessageError msg builtin: simplify MessageError.msg() May 18, 2024
spytheman added a commit to spytheman/coreutils that referenced this pull request May 18, 2024
@spytheman
test with v from vlang/v#21524
18ba785
@spytheman spytheman mentioned this pull request May 18, 2024
Closed
@spytheman spytheman merged commit 3a3a108 into vlang:master May 18, 2024
69 checks passed
@spytheman spytheman deleted the builtin_simplify_MessageError_msg branch May 18, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@spytheman