toml: fix @[toml: ], support @[skip]
#21571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice contrib @heyimtcn. Can you add a test? I think that the attribs would need to be respected during encoding as well to have consistent behavior. |
|
patched |
heyimtcn
changed the title
toml: @[toml: ], support @[skip]
|
why do formatting checks keep failing?? i even tested it locally and it works fine... |
ttytm
reviewed
May 26, 2024
It may have been because of some interaction between vfmt, your editor or your git settings, as @ttytm noted.
I have these lines: [core]
autocrlf=input
safecrlf=falsein my .gitconfig file, if that is of any help. |
|
Right, there might have been an overwrite due to a local setting. Let us know if you spot what was causing it 😊 |
spytheman
added a commit
to felipensp/v
that referenced
this pull request
May 27, 2024
* master: cgen: fix array fixed initialization on struct from call (vlang#21568) testing: implement a separate `-show-asserts` option, for cleaner test output (`-stats` still works, and still shows both the compilation stats and the asserts) (vlang#21578) toml: fix `@[toml: ]`, support `@[skip]` (vlang#21571) os: fix debugger_present() for non Windows OSes (vlang#21573) builtin: simplify splint_nth methods (vlang#21563) net.http: change default http.Server listening address to :9009, to avoid conflicts with tools, that start their own http servers on 8080 like bytehound (vlang#21570) os: make minior improvement to C function semantics and related code (vlang#21565) io: cleanup prefix_and_suffix/1 util function (vlang#21562) os: remove mut declarions for unchanged vars in `os_nix.c.v` (vlang#21564) builtin: reduce allocations in s.index_kmp/1 and s.replace/2 (vlang#21561) ci: shorten path used for unix domain socket tests (to fit in Windows path limits)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
toml.decode_struct[T]()to supportfield @[toml: name]