Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Change device info "default_manufacturer" to "manufacturer" - Fix for HA 2023.8 #154

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Change device info "default_manufacturer" to "manufacturer" - Fix for HA 2023.8 #154

merged 1 commit into from
Aug 5, 2023

Conversation

RobertD502
Copy link
Contributor

@RobertD502 RobertD502 commented Jul 27, 2023

Currently running the beta for Home Assistant 2023.8. It looks like they have introduced a validator in the device registry that now checks the validity of an entity's device info.

Starting with 2023.8, the following error is logged for all entities:

Logger: homeassistant.components.number
Source: helpers/entity_platform.py:624
Integration: Number (documentation, issues)
First occurred: 7:06:46 PM (2 occurrences)
Last logged: 7:06:46 PM

Ignoring invalid device info: Invalid device info {'default_manufacturer': 'VeSync', 'identifiers': {('vesync', 'vsaqf650392470db518f6893d5e0f296')}, 'model': 'Classic300S', 'name': 'Bedroom Humidifier', 'sw_version': None} for 'vesync' config entry: device info needs to either describe a device, link to existing device or provide extra information.

The default_manufacturer key is part of secondary device info while the rest of the device info that you have is primary. This mix between primary and secondary info causes a DeviceInfoError exception to be raised.

Changing the key to manufacturer instead makes Home Assistant happy as now all parts of the device info provided are primary.

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mkennel
Copy link

mkennel commented Aug 5, 2023

Please approve this pull request, This fixes an issue on my instance where devices stop working and when readded they are added as entities only.

@vlebourl vlebourl merged commit 890c4ea into vlebourl:main Aug 5, 2023
8 checks passed
@vlebourl
Copy link
Owner

vlebourl commented Aug 5, 2023

Thanks a lot!

@RobertD502 RobertD502 deleted the device_info_fix branch August 5, 2023 21:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants