Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement trimesh import #21

Merged
merged 26 commits into from Jan 23, 2023
Merged

Implement trimesh import #21

merged 26 commits into from Jan 23, 2023

Conversation

janhohenheim
Copy link
Contributor

@janhohenheim janhohenheim commented Jan 21, 2023 •
edited

This acts as preparation for vleue/vleue_navigator#7
Implements #20 as well, but I can remove it again if you disagree

@janhohenheim janhohenheim mentioned this pull request Jan 21, 2023
Merged
2 tasks
mockersf
mockersf approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple of nits but mostly because I like %

src/trimesh.rs Outdated Show resolved Hide resolved
src/trimesh.rs Outdated Show resolved Hide resolved
janhohenheim and others added 2 commits January 23, 2023 23:33
@janhohenheim @mockersf
Use modulo instead of branch
21626cf 
Co-authored-by: François <mockersf@gmail.com>
@janhohenheim @mockersf
Use modulo instead of branch
a85761f 
Co-authored-by: François <mockersf@gmail.com>
@janhohenheim
Copy link
Contributor Author

Good catch with the modulo, thanks! Done.

@mockersf mockersf merged commit ddbddf2 into vleue:main Jan 23, 2023
@janhohenheim janhohenheim deleted the import-trimesh branch January 23, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janhohenheim @mockersf