-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Simple API token authentication #1106
Conversation
Any ideas when this will be merged? |
Hi @taisazero, thank you for your PR. Can you help modify the code to simplify it:
Thank you again! |
@simon-mo I cleaned up the other TODO's. For using middleware do you mean something like this link to remove the need for |
Yes. I believe instead of depends, using Additionally, let's make it so the the authentication behaves the following:
If you can add a snippet to the documentation, that would be even better! Thank you |
@taisazero please let me know if you need any help in the described items! |
I'll get to it -- just have a lot of deadlines right now 😭 |
Awesome! Long for this! |
It would be awesome to have this feature merged. Thanks for working on it @taisazero |
I added a few messages to instruct folk to install fschat and accelerate (due to a nested dependency).
I also added native FastAPI access token authentication to vllm's openai server and vanilla server.