Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin PyTorch & xformers versions #2155

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Pin PyTorch & xformers versions #2155

merged 2 commits into from
Dec 17, 2023

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Dec 17, 2023

Let's pin the PyTorch and xformers versions so that updates in PyTorch or xformers do not break vLLM.

Also, the vLLM + CUDA 11.8 package build fails if pytorch-version in publish.yml is not the most recent version that meets requirements.txt. Pinning the PyTorch and xformers versions will solve this issue.

Copy link
Collaborator

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix!

@WoosukKwon WoosukKwon merged commit b0a1d66 into main Dec 17, 2023
2 checks passed
@WoosukKwon WoosukKwon deleted the fix-torch-version branch December 17, 2023 09:46
xjpang pushed a commit to xjpang/vllm that referenced this pull request Dec 18, 2023
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants