Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo fix #2166

Merged
merged 1 commit into from
Dec 18, 2023
Merged

typo fix #2166

merged 1 commit into from
Dec 18, 2023

Conversation

oushu1zhangxiangxuan1
Copy link
Contributor

image

WoosukKwon
WoosukKwon approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for submitting the PR.

@WoosukKwon WoosukKwon merged commit bbe4466 into vllm-project:main Dec 18, 2023
2 checks passed
xjpang pushed a commit to xjpang/vllm that referenced this pull request Dec 18, 2023
@oushu1zhangxiangxuan1
[Minor] Fix typo (vllm-project#2166)
705913f 
Co-authored-by: John-Saxon <zhang.xiangxuan@oushu.com>
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@oushu1zhangxiangxuan1
[Minor] Fix typo (vllm-project#2166)
ce608d6 
Co-authored-by: John-Saxon <zhang.xiangxuan@oushu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oushu1zhangxiangxuan1 @WoosukKwon