Build docker image with shared objects from "build" step #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes sure that any .so files present in the directory during the docker build get overwritten by those of the build stage. This can happen if you have previously run `pip install -e .` in the same folder
jedibrillo
pushed a commit
to jedibrillo/vllm
that referenced
this pull request
Jan 5, 2024
hmellor
deleted the
overwrite-any-local-shared-objects-with-container-contents
branch
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that any .so files present in the local directory are not copied to the docker container where they would overwrite the result of the build stage.
This can happen if you have previously run
pip install -e .in the same folder