Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix API server test #2270

Merged
merged 2 commits into from
Dec 26, 2023
Merged

[BUGFIX] Fix API server test #2270

merged 2 commits into from
Dec 26, 2023

Conversation

zhuohan123
Copy link
Collaborator

Previously tests/async_engine/test_api_server.py would always be in a dead loop.

@zhuohan123 zhuohan123 mentioned this pull request Dec 26, 2023
Merged
WoosukKwon
WoosukKwon approved these changes Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix! I actually experienced the bug previously, but forgot to report it. Happy to see that it's now fixed anyway! 😃

@WoosukKwon WoosukKwon merged commit 66b108d into main Dec 26, 2023
2 checks passed
@WoosukKwon WoosukKwon deleted the fix-test-api-server branch December 26, 2023 18:37
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@zhuohan123
[BUGFIX] Fix API server test (vllm-project#2270)
e3bbba0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

@Yard1 Yard1 Awaiting requested review from Yard1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhuohan123 @WoosukKwon