Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] add support to ROCm 6.0 and MI300 #2274

Merged
merged 17 commits into from
Jan 26, 2024
Merged

[ROCm] add support to ROCm 6.0 and MI300 #2274

merged 17 commits into from
Jan 26, 2024

Conversation

hongxiayang
Copy link
Contributor

This diff adds support to ROCm 6.0 and MI300

@hongxiayang hongxiayang marked this pull request as draft December 26, 2023 19:44
@WoosukKwon
Copy link
Collaborator

Hi @hongxiayang, thanks for submitting this PR! Please let us know when the PR is ready for review.

sunway513
sunway513 reviewed Jan 2, 2024
View reviewed changes
Dockerfile.rocm.6.0 Outdated Show resolved Hide resolved
dllehr-amd
dllehr-amd reviewed Jan 4, 2024
View reviewed changes
Dockerfile.rocm Outdated Show resolved Hide resolved
pruthvistony
pruthvistony reviewed Jan 4, 2024
View reviewed changes
Dockerfile.rocm Show resolved Hide resolved
vllm/worker/worker.py Outdated Show resolved Hide resolved
@hongxiayang
Copy link
Contributor Author

Hi @hongxiayang, thanks for submitting this PR! Please let us know when the PR is ready for review.

sure, will let you know. I am in the process updating the base image to ROCm 6.0

@hongxiayang hongxiayang marked this pull request as ready for review January 6, 2024 00:26
@hongxiayang
Copy link
Contributor Author

Hi @hongxiayang, thanks for submitting this PR! Please let us know when the PR is ready for review.

@WoosukKwon It is ready for review now. Not sure why all the ci jobs (buildkite/ci/pr/pipeline and buildkite/ci/pr) failed.

hongxiayang
hongxiayang commented Jan 8, 2024
View reviewed changes
vllm/utils.py Outdated Show resolved Hide resolved
@hongxiayang hongxiayang marked this pull request as draft January 8, 2024 21:54
@hongxiayang hongxiayang marked this pull request as ready for review January 8, 2024 22:55
tjtanaa
tjtanaa approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@tjtanaa tjtanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simon-mo simon-mo merged commit 6b7de1a into vllm-project:main Jan 26, 2024
17 checks passed
NikolaBorisov pushed a commit to deepinfra/vllm that referenced this pull request Jan 31, 2024
@hongxiayang @NikolaBorisov
[ROCm] add support to ROCm 6.0 and MI300 (vllm-project#2274)
ecc15ce
hongxiayang added a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@hongxiayang
[ROCm] add support to ROCm 6.0 and MI300 (vllm-project#2274)
93436c1
alexm-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Feb 13, 2024
@hongxiayang @alexm-neuralmagic
[ROCm] add support to ROCm 6.0 and MI300 (vllm-project#2274)
5507e8c
@andy-neuma andy-neuma mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunway513 sunway513 sunway513 left review comments

@zhuohan123 zhuohan123 zhuohan123 left review comments

@pruthvistony pruthvistony pruthvistony left review comments

@dllehr-amd dllehr-amd dllehr-amd left review comments

@simon-mo simon-mo simon-mo approved these changes

@tjtanaa tjtanaa tjtanaa approved these changes

Assignees
No one assigned
Labels
rocm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@hongxiayang @WoosukKwon @sunway513 @zhuohan123 @simon-mo @tjtanaa @pruthvistony @dllehr-amd