Add support GPT-NeoX Models without attention biases #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosukKwon
reviewed
Dec 30, 2023
There was a problem hiding this comment.
Hi @dalgarak, thanks for submitting the PR. It seems we can simplify the change a bit. Please take a look at the review.
Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
WoosukKwon
approved these changes
Dec 30, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables support for GPT-NeoX models without attention bias.
All models with the currently released GPT-NeoX architecture use attention bias by default, but the next version of huggingface transformers will support models without attention bias (merged PR - huggingface/transformers#28126), and we want to modify the code to properly initialize these models in vLLM as well.
In previous versions of the transformers, there was no attention_bias argument in GPTNeoXConfig, so we used hasattr() to apply a default value to avoid compatibility issues with version differences.