Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused const TIMEOUT_TO_PREVENT_DEADLOCK #2321

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

ronensc
Copy link
Contributor

@ronensc ronensc commented Jan 2, 2024

It appears that the following constant is not used anywhere, so I believe it can be safely removed.

TIMEOUT_TO_PREVENT_DEADLOCK = 1 # seconds.

Copy link
Collaborator

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@zhuohan123 zhuohan123 merged commit 74d8d77 into vllm-project:main Jan 3, 2024
2 checks passed
@ronensc ronensc deleted the remove-const branch January 4, 2024 10:05
jedibrillo pushed a commit to jedibrillo/vllm that referenced this pull request Jan 5, 2024
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants