Ensure metrics are logged regardless of requests #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice catch! although a better UX would be to reset it just once so vLLM won't be spamming the same log message telling idle status every 10s. i'm having trouble coming up with a clean way to do it though. |
|
If you have the instance running in kubernetes, every 15s it queries the /metrics and prints in the logs. If you really want to avoid the vllm log part (where it logs zeros over and over), I can add some ifs. I think it's not needed, let me know. |
|
@simon-mo I'm a bit confused about the ray/remote logic. Should I call the |
Metrics are currently logged at the end of each step, but if there are no requests there are no new logs/metrics, so the last values are reported to prometheus indefinitely. Also, for some reason, it always reports one running request.
simon-mo
approved these changes
Jan 5, 2024
Comment on lines
+511
to
+512
| if self.engine_use_ray: | ||
| await self.engine.do_log_stats.remote() |
|
@ichernev thanks again. I think the current state is fine, therefore, merged. We can revisit this if people find the logs too spammy. |
jedibrillo
pushed a commit
to jedibrillo/vllm
that referenced
this pull request
Jan 5, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Jan 18, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics are currently logged at the end of each step, but if there are no requests there are no new logs/metrics, so the last values are reported to prometheus indefinitely.
Also, for some reason, it always reports one running request.