Update a more user-friendly error message, offering more considerate advice for beginners, when using V100 GPU #1901 #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the error message, suggesting users to add --dtype="half" to specify the data type.
simon-mo
approved these changes
Jan 12, 2024
|
🤦♂️ i mis-typed the commit message. This is not about OOM, it's about support for bfloat16 |
WoosukKwon
reviewed
Jan 12, 2024
| @@ -231,4 +231,6 @@ def _check_if_gpu_supports_dtype(torch_dtype: torch.dtype): | |||
| raise ValueError( | |||
| "Bfloat16 is only supported on GPUs with compute capability " | |||
| f"of at least 8.0. Your {gpu_name} GPU has compute capability " | |||
| f"{compute_capability[0]}.{compute_capability[1]}.") | |||
| f"{compute_capability[0]}.{compute_capability[1]}." | |||
| f" You can explicitly specify the data type by using the --dtype option, for example: --dtype=half." | |||
There was a problem hiding this comment.
This exceeds our maximum line length. It's unfortunate that our format checker did not detect this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the sake of future beginners, it is suggested to provide guidance in the error message, suggesting users to add --dtype="half" to specify the data type.
in issue #1901