-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Phi modeling update 2 #2428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! I have tested phi 1, 1.5, and 2.
curl http://localhost:8000/v1/completions \
-H "Content-Type: application/json" \
-d '{
"model": "microsoft/phi-1_5",
"prompt": "San Francisco is a",
"max_tokens": 20,
"temperature": 0
}'
{"id":"cmpl-dc39c048711b453fb0e5e5930b0501a1","object":"text_completion","created":82988,"model":"microsoft/phi-1_5","choices":[{"index":0,"text":" city that has a lot of history and culture. It has a lot of buildings and monuments that tell","logprobs":null,"finish_reason":"length"}],"usage":{"prompt_tokens":4,"total_
(base) xmo@simon-devbox:~$ curl http://localhost:8000/v1/completions -H "Content-Type: application/json" -d '{
"model": "microsoft/phi-2",
"prompt": "San Francisco is a",
"max_tokens": 20,
"temperature": 0
}'
{"id":"cmpl-0cca6c5891f64b1bb312553341c3505f","object":"text_completion","created":83037,"model":"microsoft/phi-2","choices":[{"index":0,"text":" city that is known for its diverse population and vibrant culture. However, it is also a city that","logprobs":null,"finish_reason":"length"}],"usage":{"prompt_tokens":4,"total_tokens":24,"completion_tokens":20}}
(base) xmo@simon-devbox:~$ curl http://loctent-Type: application/json" -d '{t
"model": "microsoft/phi-1",
"prompt": "San Francisco is a",
"max_tokens": 20,
"temperature": 0
}'
{"id":"cmpl-d218bd0bbcfc4b97bdb107382fb42281","object":"text_completion","created":83158,"model":"microsoft/phi-1","choices":[{"index":0,"text":" city located on the intersection of New York City and Los Angeles. It is located in the vicinity of","logprobs":null,"finish_reason":"length"}],"usage":{"prompt_tokens":4,"total_tokens":24,"completion_tokens":20}}(base) xmo@simon-devbox:~$
simon-mo
reviewed
Jan 12, 2024
Please fix the formatting by running |
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jan 14, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Jan 18, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed variable name and weight name mismatch mentioned in #2383.