Don't download both safetensor and bin files. #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now vllm when trying to download the weights will download both safetensor and bin files which is bad. This change fixes it
|
@simon-mo Can you please take a quick look. This is short, and would save petabytes of downloads |
|
Can you give me an example of model with this kind of double download behavior so I can test it out? |
|
ok testing with https://huggingface.co/meta-llama/Llama-2-7b-chat-hf/tree/main |
simon-mo
approved these changes
Jan 18, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Jan 18, 2024
hongxiayang
added a commit
to hongxiayang/vllm
that referenced
this pull request
Jan 18, 2024
)" This reverts commit d246a38.
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now vllm is downloading both safetensor and bin files which is bad. This change fixes it.
To reproduce try running a model that has both safetensor and bin files.