Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix some args desc #2487

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: fix some args desc #2487

merged 1 commit into from
Jan 18, 2024

Conversation

zspo
Copy link
Contributor

@zspo zspo commented Jan 18, 2024

Fix some parameter descriptions

zhuohan123
zhuohan123 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fix!

@zhuohan123 zhuohan123 merged commit 4df417d into vllm-project:main Jan 18, 2024
16 checks passed
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Jan 18, 2024
@zspo @hongxiayang
fix: fix some args desc (vllm-project#2487)
334da4b
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@zspo
fix: fix some args desc (vllm-project#2487)
164768e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuohan123 zhuohan123 zhuohan123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zspo @zhuohan123