Minor fix in prefill cache example #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhuohan123 @DouHappy @caoshiyi Thanks for adding prefill cache capability, could you help review this pr for a minor fix? |
zhuohan123
approved these changes
Jan 18, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Jan 18, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In offline_inference_with_prefix.py, we pass a batch of prompts with prefix_pos to the llm.generate call. However, the llm.generate call will batch all prompts and send the batch at once if resources allow. The prefix will only be cached after the first batch is processed, so we need to call generate once to calculate the prefix, cache it, and then use a subsequent call to leverage the cached prefix.
Note: This issue was identified while attempting to do prefix cache for mistral7b, which is not supported with a sliding window. Nevertheless, this call will succeed because only the initial prefix attention computation is executed.
Test
Test done for llama7b model