refactor completion api for readability #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
approved these changes
Jan 19, 2024
| use_beam_search=self.use_beam_search, | ||
| prompt_logprobs=self.logprobs if self.echo else None, | ||
| skip_special_tokens=self.skip_special_tokens, | ||
| spaces_between_special_tokens=(self.spaces_between_special_tokens), |
There was a problem hiding this comment.
Code formatting looks better with this.
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds no new functionality, it just makes completion api a lot easier to read and maintain. before it has one spaghetti function spanning few hundred lines, after this PR, the situation should be greatly improved. chat completion api doesn't have this problem because it is fairly modularized.
I'm doing this in preparation for batch completions support.