Add group as an argument in broadcast ops
#2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
approved these changes
Jan 20, 2024
| @@ -86,47 +86,55 @@ def tensor_model_parallel_gather(input_: torch.Tensor, | |||
| return output_tensor | |||
|
|
|||
|
|
|||
| def broadcast(input_: torch.Tensor, src: int = 0): | |||
| def broadcast(input_: torch.Tensor, src: int = 0, group=None): | |||
There was a problem hiding this comment.
Please add type annotation, and ditto below
Suggested change
| def broadcast(input_: torch.Tensor, src: int = 0, group=None): | |
| def broadcast(input_: torch.Tensor, src: int = 0, group: Optional[ProcessGroup] = None): |
There was a problem hiding this comment.
Thanks for reviewing! I committed the new changes as you suggested (with an import of the ProcessGroup symbol).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up with #2501.
Changes
In
communication_ops.py, addgroupas an argument in thebroadcastauxiliary function family. This helps designate the group to communicate (for example, a designated tensor-parallel group, or pipeline-parallel group) in the future.