Add a 1-line docstring to explain why calling context_attention_fwd twice in test_prefix_prefill.py #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
approved these changes
Jan 22, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
…wice in test_prefix_prefill.py (vllm-project#2553)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially it was confusing to me why we call it twice repeatedly, later found out it was for warming up the triton kernel, just add 1-linear doc string:
Calling it once (warmup):
triton Time: 15.10 ms
xformers Time: 0.61 ms
Calling it twice (after warmup):
triton Time: 1.95 ms
xformers Time: 0.62 ms