Added include_stop_str_in_output and length_penalty parameters to OpenAI API
#2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and CompletionRequest
galatolofederico
changed the title
include_stop_str_in_output parameter to ChatCompletionRequest and CompletionRequestinclude_stop_str_in_output and length_penalty parameters to OpenAI API
galatolofederico
force-pushed
the
main
branch
from
1ebd636
to
e418340
Compare
zhuohan123
approved these changes
Jan 24, 2024
|
Nice fix! |
NikolaBorisov
pushed a commit
to deepinfra/vllm
that referenced
this pull request
Jan 31, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
include_stop_str_in_outputandlength_penaltysampling parameters (defined here) to the OpenAI API parameters.Note: The force push addresses a missing comma, corrected without making a new commit for a minor syntax fix.