Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] fix crash if max_tokens=None #2570

Merged
merged 4 commits into from
Jan 24, 2024
Merged

[Bugfix] fix crash if max_tokens=None #2570

merged 4 commits into from
Jan 24, 2024

Commits on Jan 24, 2024

  1. fix crash if max_tokens=None 

    Passing max_tokens=None is allowed in the API,
but after recent changes it started crashing.
    @NikolaBorisov
    NikolaBorisov committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    43e7268 View commit details
    Browse the repository at this point in the history

  2. Add tests

    @NikolaBorisov
    NikolaBorisov committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    6bab518 View commit details
    Browse the repository at this point in the history

  3. Add test file for sampling params

    @NikolaBorisov
    NikolaBorisov committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    b3fcf05 View commit details
    Browse the repository at this point in the history

  4. fix formatting

    @NikolaBorisov
    NikolaBorisov committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    db93a93 View commit details
    Browse the repository at this point in the history