ROCm: Allow setting compilation target #2581
Merged
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rlrs, thanks for submitting the PR. A quick question: How is the environment variable different from |
|
|
18 tasks
WoosukKwon
approved these changes
Jan 29, 2024
|
Oh it seems like |
NikolaBorisov
pushed a commit
to deepinfra/vllm
that referenced
this pull request
Jan 31, 2024
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
alexm-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, building the package requires a machine that has a GPU with the desired architecture. This is however not necessary, you can easily compile for another target, even if the build machine has no GPU at all.
This PR simply enables one to set the
GPU_ARCHSenvironment variable, for example asGPU_ARCHS=gfx90aor GPU_ARCHS=gfx90a;gfx1100` if you want to build for multiple targets.This resolves #2127.