Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when tp > 1 #2644

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix error when tp > 1 #2644

merged 1 commit into from
Jan 29, 2024

Conversation

zhaoyang-star
Copy link
Contributor

Fix issue #2640

Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix!

@zhaoyang-star
Copy link
Contributor Author

@WoosukKwon All ci checks have passed. Please merge it to solve issue #2640

@WoosukKwon WoosukKwon merged commit b72af8f into vllm-project:main Jan 29, 2024
17 checks passed
@zhaoyang-star zhaoyang-star deleted the fix_tp branch January 29, 2024 06:55
NikolaBorisov pushed a commit to deepinfra/vllm that referenced this pull request Jan 31, 2024
Co-authored-by: zhaoyang-star <zhao.yang16@zte.com.cn>
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
Co-authored-by: zhaoyang-star <zhao.yang16@zte.com.cn>
alexm-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Feb 13, 2024
Co-authored-by: zhaoyang-star <zhao.yang16@zte.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants