Fix setup.py neuron-ls issue #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
approved these changes
Feb 4, 2024
| if _is_cuda(): | ||
| with open(get_path("requirements.txt")) as f: | ||
| requirements = f.read().strip().split("\n") | ||
| elif _is_hip(): | ||
| with open(get_path("requirements-rocm.txt")) as f: | ||
| requirements = f.read().strip().split("\n") | ||
| elif _is_neuron(): | ||
| with open(get_path("requirements-neuron.txt")) as f: | ||
| requirements = f.read().strip().split("\n") |
There was a problem hiding this comment.
Add an else statement here and raise an error in it?
setup.py
Outdated
|
|
||
| def _is_cuda() -> bool: | ||
| return (torch.version.cuda is not None) and not _is_neuron() | ||
| return shutil.which("neuron-ls") is not None |
There was a problem hiding this comment.
Just to let you know, I tried implementing just this line and it doesn't work on an AWS AMI as the neuron-ls package is installed, but if you're not on a neuron device then it still fails. What worked for me was to just change the errors caught on line 39 to include 'subprocess.CalledProcessError'.
There was a problem hiding this comment.
Thanks! updated my PR to reflect that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2661