Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Fix false warning when TP=1 #2674

Merged
merged 1 commit into from
Jan 30, 2024
Merged

[Minor] Fix false warning when TP=1 #2674

merged 1 commit into from
Jan 30, 2024

Conversation

WoosukKwon
Copy link
Collaborator

This PR removes the unnecessary warning:

WARNING 01-30 21:39:03 custom_all_reduce.py:33] Custom allreduce is disabled due to an unsupported world size: 1. Supported world sizes: [2, 4, 6, 8]. To slience this warning, specifydisable_custom_all_reduce=True explicitly.

@WoosukKwon WoosukKwon merged commit 105a40f into main Jan 30, 2024
17 checks passed
@WoosukKwon WoosukKwon deleted the minor-custom-ar branch January 30, 2024 22:39
NikolaBorisov pushed a commit to deepinfra/vllm that referenced this pull request Jan 31, 2024
@WoosukKwon @NikolaBorisov
[Minor] Fix false warning when TP=1 (vllm-project#2674)
b18a0b3
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@WoosukKwon
[Minor] Fix false warning when TP=1 (vllm-project#2674)
c4c0d08
alexm-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Feb 13, 2024
@WoosukKwon @alexm-neuralmagic
[Minor] Fix false warning when TP=1 (vllm-project#2674)
04fd85f
@andy-neuma andy-neuma mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WoosukKwon @simon-mo