Use CuPy for CUDA graphs #2811
Merged
Use CuPy for CUDA graphs #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yard1
reviewed
Feb 8, 2024
| @@ -71,7 +73,7 @@ def init_process_group(world_size: int, rank: int, host: str, | |||
|
|
|||
| if isinstance(cupy, Exception): | |||
| raise ImportError( | |||
| "NCCLBackend is not available. Please install cupy.") from cupy | |||
| "NCCLBackend is not available. Please install cupy==13.0.0.") from cupy | |||
There was a problem hiding this comment.
Suggested change
| "NCCLBackend is not available. Please install cupy==13.0.0.") from cupy | |
| "NCCLBackend is not available. Please install cupy-cuda12x==13.0.0.") from cupy |
There was a problem hiding this comment.
Thanks for pointing it out. Actually, there are two issues:
- I changed the PR to use cupy 12.3 instead of 13.0 because cupy 13.0 does not support python 3.8 (I wasn't able to find the wheel in pypi).
- Users need to install different versions of cupy depending on their env. For example, CUDA 11.8 users should install cupy-cuda11x. ROCm users should install cupy-rocm.
Yard1
reviewed
Feb 8, 2024
|
@WoosukKwon FYI custom allreduce doesn't work for all cases (e.g. 8 PCIE gpus) so this fix might be needed anyway |
|
I think #2731 might be related. |
jvmncs
pushed a commit
to jvmncs/vllm
that referenced
this pull request
Feb 14, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Feb 20, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Feb 22, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for the memory leak issue when using CUDA graph w/o the custom all-reduce kernel. The PR uses CuPy NCCL instead of PyTorch NCCL.