Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix assertion on Mistral YaRN model len #2984

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[Fix] Fix assertion on Mistral YaRN model len #2984

merged 1 commit into from
Feb 23, 2024

Conversation

WoosukKwon
Copy link
Collaborator

For Mistral + YaRN models such as NousResearch/Yarn-Mistral-7b-128k, the current assertion does not hold. This PR deletes it.

@WoosukKwon WoosukKwon changed the title [Fix] Fissertion on Mistral YaRN model len [Fix] Fix assertion on Mistral YaRN model len Feb 22, 2024
zhuohan123
zhuohan123 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@WoosukKwon WoosukKwon merged commit f7c1234 into main Feb 23, 2024
21 checks passed
@WoosukKwon WoosukKwon deleted the yarn branch February 23, 2024 20:57
xjpang pushed a commit to xjpang/vllm that referenced this pull request Mar 4, 2024
@WoosukKwon
[Fix] Fissertion on YaRN model len (vllm-project#2984)
dbcc122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuohan123 zhuohan123 zhuohan123 approved these changes

@Yard1 Yard1 Awaiting requested review from Yard1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WoosukKwon @zhuohan123