Support arbitrary json_object in OpenAI and Context Free Grammar #3211
+178
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
changed the title
simon-mo
commented
Mar 5, 2024
|
|
||
| def __init__(self, regex_string: str, tokenizer): | ||
| """Compile the FSM that drives the regex-structured generation. | ||
| def adapt_tokenizer(self, tokenizer): |
There was a problem hiding this comment.
simon-mo
changed the title
esmeetu
reviewed
Mar 6, 2024
|
|
||
|
|
||
| class GuidedDecodingMode(Enum): | ||
| JSON = "json" | ||
| REGEX = "regex" | ||
| CHOICE = "choice" | ||
| CFG = "cfg" |
There was a problem hiding this comment.
A dumb question: does CFG mean config? only for grammar config?
There was a problem hiding this comment.
Context free grammar, good point that I should probably change it to grammar to disambiguate
|
|
||
| class CFGLogitsProcessor(BaseLogitsProcessor): | ||
|
|
||
| def __init__(self, cfg: str, tokenizer): |
There was a problem hiding this comment.
Adding type definition for tokenizer in this whole file is better.
esmeetu
approved these changes
Mar 16, 2024
| tokenizer.decode = change_decoder(tokenizer.decode) | ||
| setattr(tokenizer, "_outlines_adapted", True) # noqa: B010 | ||
|
|
||
| return tokenizer |
|
Excellent new feature! Thanks everyone! I will definitely test it when the next vLLM release comes out. |
|
Is this available in the new vLLM library? How do I use this feature with Mixtral8x7b? |
|
This is available in latest release. https://docs.vllm.ai/en/latest/serving/openai_compatible_server.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3148
Closes #1229