fix bias in if, ambiguous #3259
Conversation
vllm/utils.py
Outdated
| @@ -178,7 +178,7 @@ def get_ip() -> str: | |||
| except OSError: | |||
| # try ipv6 | |||
| s = socket.socket(socket.AF_INET6, socket.SOCK_DGRAM) | |||
| s.connect(("dns.google", 80)) | |||
| s.connect(("2001:4860:4860:0:0:0:0:8888", 80)) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
@hliuca Why do we need this change?
There was a problem hiding this comment.
Hi, @WoosukKwon. dns.google use DoT, and maybe we should avoid DoT here.
https://developers.google.com/speed/public-dns/docs/dns-over-tls
There was a problem hiding this comment.
@chenxu2048 I see. Could you submit another PR about this? It seems to be not relevant to the PR.
There was a problem hiding this comment.
@WoosukKwon I agree with you. I'm not the authors of the PR and just commented on the "irrelevant" changing.
@hliuca Are you still working on this PR? Could you move this changing into another PR?
There was a problem hiding this comment.
@chenxu2048 I see. I thought you were the author. Sorry for that. 🤦
|
@hliuca Thanks for the PR and updating it! |
Bool value of Tensor with more than one value is ambiguous.