Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Simpler fix for async engine running on ray #3371

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

zhuohan123
Copy link
Collaborator

@zhuohan123 zhuohan123 commented Mar 13, 2024

This is a simpler fix for the bug reported in #3343. Given that ray_compiled_dag is a experimental feature. Let's try to reduce its scope.

cc @rkooo567

TODO: #3370

Copy link
Collaborator

@esmeetu esmeetu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhuohan123 zhuohan123 merged commit eeab52a into main Mar 13, 2024
22 of 24 checks passed
starmpcc pushed a commit to starmpcc/vllm that referenced this pull request Mar 14, 2024
@zhuohan123 zhuohan123 deleted the fix-ray-compiled-dag branch April 26, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants