Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chat templates for ChatGLM #3418

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Add chat templates for ChatGLM #3418

merged 1 commit into from
Mar 15, 2024

Conversation

Dinghow
Copy link
Contributor

@Dinghow Dinghow commented Mar 15, 2024

Add chat templates for ChatGLM/ChatGLM2

simon-mo
simon-mo approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is there sources of these (original repo, paper, etc) that you can include the link in the comments?

@Dinghow
Copy link
Contributor Author

Dinghow commented Mar 15, 2024

Thanks! Is there sources of these (original repo, paper, etc) that you can include the link in the comments?

ChatGLM official chat API
ChatGLM2 official chat API

@simon-mo simon-mo self-assigned this Mar 15, 2024
@simon-mo simon-mo merged commit 253a980 into vllm-project:main Mar 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees

@simon-mo simon-mo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dinghow @simon-mo