Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Add test_config.py to CI #3437

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

cadedaniel
Copy link
Collaborator

In review of #3373 I missed that the test wasn't added to CI.

Thanks to @a516072575 for catching this!

@simon-mo simon-mo enabled auto-merge (squash) March 15, 2024 20:33
@richardliaw
Copy link
Collaborator

tests failing?

@simon-mo
Copy link
Collaborator

try? huggingface network issue again? 🙃

@richardliaw
Copy link
Collaborator

do you recommend retry by merging master?

@simon-mo
Copy link
Collaborator

Or clicking retry in buildkite/push empty commit.

Copy link

@carrey-feng carrey-feng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

auto-merge was automatically disabled March 18, 2024 18:38

Head branch was pushed to by a user without write access

@cadedaniel
Copy link
Collaborator Author

fixed merge conflict;

@Yard1 Yard1 merged commit 482b0ad into vllm-project:main Mar 18, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants