-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for baichuan #365
Conversation
… compatibility" This reverts commit 30880ce.
Thanks, but I think still need to add a conversation template in FastChat since /v1/chat/completion API requires it. Or can you give a prompt template for /v1/completions, I can't wait to try this model. |
This is a good prompt template I came up with for the completions:
|
Any updates on this? I saw there a some PRs try support baichuan now, please consider merge one otherwise none of them can be properly supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your excellent contribution! This PR looks good to me. Sorry that we have been busy in the past several weeks so we didn't get a chance to review this. I just tested this out and it works great!
Closes #303
Should be merged after #364 - as the model requires its remote tokenizer to run correctly