[Bugfix] [Hotfix] fix nccl library name #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosukKwon
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually, the convention for dynamic shared library is: for nccl version 2.18.3, there would be a file
libnccl.so.2.18.3, and the following files linked to that file:libnccl.so.2.18libnccl.so.2libncclso.This is often the case for system-installed nccl, e.g. our CI machine, in
/usr/lib/x86_64-linux-gnu/libnccl.so.However, the version pytorch installs, does not follow this convention. It is just named as s single file
libnccl.so.2.This PR will make pure pytorch users happy.