Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] fix del of communicator #3702

Merged
merged 1 commit into from
Mar 29, 2024
Merged

[Core] fix del of communicator #3702

merged 1 commit into from
Mar 29, 2024

Conversation

youkaichao
Copy link
Member

dist module might have been already destroyed, add a check for better cleanup.

@simon-mo simon-mo enabled auto-merge (squash) March 28, 2024 22:51
@simon-mo simon-mo merged commit 0267fef into vllm-project:main Mar 29, 2024
34 checks passed
@youkaichao youkaichao deleted the fix_del branch March 29, 2024 00:52
xjpang pushed a commit to xjpang/vllm that referenced this pull request Mar 31, 2024
@youkaichao
[Core] fix del of communicator (vllm-project#3702)
63232c1
@youkaichao youkaichao mentioned this pull request Apr 4, 2024
Merged
@youkaichao youkaichao mentioned this pull request Apr 30, 2024
Closed
@dtrifiro dtrifiro mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@youkaichao @simon-mo