-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Speculative decoding] Adding configuration object for speculative decoding #3706
Merged
cadedaniel
merged 8 commits into
vllm-project:main
from
cadedaniel:spec-decode-llm-engine
Apr 3, 2024
Merged
[Speculative decoding] Adding configuration object for speculative decoding #3706
cadedaniel
merged 8 commits into
vllm-project:main
from
cadedaniel:spec-decode-llm-engine
Apr 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadedaniel
changed the title
[WIP] [Speculative decoding] Adding configuration object for speculative decoding
[Speculative decoding] Adding configuration object for speculative decoding
Mar 29, 2024
ready for review @LiuXiaoxuanPKU |
cadedaniel
force-pushed
the
spec-decode-llm-engine
branch
from
April 1, 2024 23:55
efc0278
to
7bc7532
Compare
cadedaniel
force-pushed
the
spec-decode-llm-engine
branch
from
April 2, 2024 03:51
8fad4f5
to
1aefa81
Compare
LiuXiaoxuanPKU
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Lily Liu <lilyliupku@gmail.com>
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
Apr 22, 2024
…coding (vllm-project#3706) Co-authored-by: Lily Liu <lilyliupku@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a subset of
PR 6/9: Integrate speculative decoding with LLMEngine.
in the speculative decoding open sourcing plan. It introduces a SpeculativeConfig and plumbs it through to the executors. The new flags are as follows:In the future we can extend these flags to support non-draft-model speculative decoding.
Testing
Misc.
EngineConfig
. This removes the need to doparallel_config = engine_configs[2]
anddevice_config = engine_configs[4]
.