Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Change /generate response-type to json for non-streaming #374

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

nicolasf
Copy link
Contributor

@nicolasf nicolasf commented Jul 5, 2023

Adds content-type=application/json on the /generate API response when not using streaming.

This fixes automatic deserialization when calling the API in Java using RestTemplate.

Copy link
Collaborator

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution to vLLM! Fixed a small import order issue.

@zhuohan123 zhuohan123 merged commit be54f8e into vllm-project:main Jul 7, 2023
2 checks passed
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants