Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update installation doc for build from source and explain the dependency on torch/cuda version #3746

Merged
merged 4 commits into from
Mar 30, 2024

Conversation

youkaichao
Copy link
Member

Recently we received multiple issues for installing from source, and the situation becomes even worse when we change to cmake build system #2830 , where pytorch cmake explicitly search for CUDA_HOME.

This PR adds instructions for users to install full cudatoolkit. And it also explains that wheel install is only available under the same cuda & pytorch version.

Copy link
Collaborator

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks


.. code-block:: console

$ # Install vLLM with CUDA 11.8.
$ export VLLM_VERSION=0.2.4
$ export VLLM_VERSION=0.4.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way that we can keep this version number updated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emmm that might need something like rst file templates. I don't think we need to go that far. Even if the number is outdated, users should know they need to change it according to their need.

docs/source/getting_started/installation.rst Outdated Show resolved Hide resolved
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
@youkaichao youkaichao merged commit 9c82a1b into vllm-project:main Mar 30, 2024
34 checks passed
@youkaichao youkaichao deleted the install_doc branch March 30, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants