[Core] manage nccl via a pypi package & upgrade to pt 2.2.1 #3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youkaichao
changed the title
youkaichao
changed the title
WoosukKwon
reviewed
Apr 4, 2024
There was a problem hiding this comment.
@youkaichao Awesome! Thanks for the great work! ! I didn't realize that updating PyTorch could be this challenging. Left minor comments. Please check them out.
| @@ -17,3 +17,4 @@ pynvml == 11.5.0 | |||
| triton >= 2.1.0 | |||
| outlines == 0.0.34 | |||
| tiktoken == 0.6.0 # Required for DBRX tokenizer | |||
| vllm-nccl-cu12>=2.18<2.19 # for downloading nccl library | |||
There was a problem hiding this comment.
Can we do this?
Suggested change
| vllm-nccl-cu12>=2.18<2.19 # for downloading nccl library | |
| vllm-nccl-cu12>=2.18.3<2.19 # for downloading nccl library |
There was a problem hiding this comment.
Fun fact: actually I have https://pypi.org/project/vllm-nccl-cu12/2.18.1.0.1.0/ , which is nccl 2.18.1 . I don't find nccl 2.18.3 at https://developer.download.nvidia.com/compute/redist/nccl/ .
WoosukKwon
reviewed
Apr 4, 2024
WoosukKwon
approved these changes
Apr 4, 2024
This was referenced Apr 4, 2024
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3802 for why we don't use another pypi packge to manage nccl .
See NVIDIA/nccl#1234 on why we have to manage nccl when upgrading to pt 2.2.1 .
Usage: