Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Fix linter issues in examples/fp8/quantizer/quantize.py #3864

Merged
merged 1 commit into from
Apr 5, 2024
Merged

[Misc] Fix linter issues in examples/fp8/quantizer/quantize.py #3864

merged 1 commit into from
Apr 5, 2024

Conversation

cadedaniel
Copy link
Collaborator 

$ ./format.sh 
vLLM yapf: Done                                                                                                                        
vLLM codespell: Done                                               
vLLM ruff:                                                                                                                                                                                                                                                                    
examples/fp8/quantizer/quantize.py:1:81: E501 Line too long (103 > 80)
examples/fp8/quantizer/quantize.py:134:81: E501 Line too long (88 > 80)
examples/fp8/quantizer/quantize.py:162:81: E501 Line too long (84 > 80)                                                                                                                                                                                                       
examples/fp8/quantizer/quantize.py:248:81: E501 Line too long (99 > 80)
examples/fp8/quantizer/quantize.py:252:81: E501 Line too long (92 > 80)
examples/fp8/quantizer/quantize.py:253:81: E501 Line too long (97 > 80)
examples/fp8/quantizer/quantize.py:254:81: E501 Line too long (94 > 80)
examples/fp8/quantizer/quantize.py:291:81: E501 Line too long (83 > 80)
Found 8 errors.

@cadedaniel cadedaniel enabled auto-merge (squash) April 5, 2024 03:14
@simon-mo
Copy link
Collaborator

simon-mo commented Apr 5, 2024

hmm not sure why ci passed

vllm/.github/workflows/ruff.yml

Line 31 in c391e4b

ruff .

auto-merge was automatically disabled April 5, 2024 04:52

Base branch was modified

@cadedaniel cadedaniel merged commit e0dd4d3 into vllm-project:main Apr 5, 2024
35 checks passed
@cadedaniel cadedaniel deleted the fix-lint-issues branch April 5, 2024 04:57
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request Apr 22, 2024
@cadedaniel @joerunde
[Misc] Fix linter issues in examples/fp8/quantizer/quantize.py (vllm-…
1bc8014 
…project#3864)
@dtrifiro dtrifiro mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cadedaniel @simon-mo