Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trust_remote_code arg to get_config #405

Merged
merged 3 commits into from
Jul 8, 2023
Merged

Add trust_remote_code arg to get_config #405

merged 3 commits into from
Jul 8, 2023

Conversation

WoosukKwon
Copy link
Collaborator

This PR adds the trust_remote_code argument to the get_config function.

zhuohan123
zhuohan123 requested changes Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Left some comments.

vllm/transformers_utils/config.py Show resolved Hide resolved
zhuohan123
zhuohan123 approved these changes Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@WoosukKwon WoosukKwon merged commit ddfdf47 into main Jul 8, 2023
2 checks passed
@WoosukKwon WoosukKwon deleted the fix-get-config branch July 8, 2023 22:24
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@WoosukKwon
Add trust_remote_code arg to get_config (vllm-project#405)
46a4606
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
@WoosukKwon
Add trust_remote_code arg to get_config (vllm-project#405)
31c6995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuohan123 zhuohan123 zhuohan123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WoosukKwon @zhuohan123