Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix ray workers profiling with nsight #4095

Merged
merged 1 commit into from
Apr 15, 2024
Merged

[Bugfix] Fix ray workers profiling with nsight #4095

merged 1 commit into from
Apr 15, 2024

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Apr 15, 2024 •
edited

Fix the nsight profiling feature added in #3162

python benchmarks/benchmark_latency.py --model=meta-llama/Llama-2-7b-chat-hf  --input-len 1000 --output-len 50 -
tp 2 --num-iters 5 --batch-size 1 --ray-workers-use-nsight

@cadedaniel cadedaniel merged commit 4695397 into vllm-project:main Apr 15, 2024
45 checks passed
robertgshaw2-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 21, 2024
@rickyyx @robertgshaw2-neuralmagic
[Bugfix] Fix ray workers profiling with nsight (vllm-project#4095)
dd069a3
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request Apr 22, 2024
@rickyyx @joerunde
[Bugfix] Fix ray workers profiling with nsight (vllm-project#4095)
121f0aa
robertgshaw2-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 26, 2024
@rickyyx @robertgshaw2-neuralmagic
[Bugfix] Fix ray workers profiling with nsight (vllm-project#4095)
6800f95
@dtrifiro dtrifiro mentioned this pull request May 15, 2024
Merged
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request Jun 3, 2024
@rickyyx @mawong-amd
[Bugfix] Fix ray workers profiling with nsight (vllm-project#4095)
f5c4d84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadedaniel cadedaniel cadedaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rickyyx @cadedaniel