Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vocab padding for LLama(Support WizardLM) #411

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

esmeetu
Copy link
Collaborator

@esmeetu esmeetu commented Jul 9, 2023

This PR add support for WizardLM-13B. When running with args: tensor-parallel-size 2, it will throw AssertionError: 32001 is not divisible by 2.
The reason is WizardLM's vocab size is 32001, and is not divisible by 2.
So i reference gpt2.py to add vocab padding for llama.py and it works.

Copy link
Collaborator

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution! Could you fix the style so we can merge the code?

@zhuohan123 zhuohan123 merged commit 7b6ae94 into vllm-project:main Jul 14, 2023
2 checks passed
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants