Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] [CI] Fix CI failure caught after merge #4126

Merged
merged 1 commit into from
Apr 17, 2024
Merged

[Misc] [CI] Fix CI failure caught after merge #4126

merged 1 commit into from
Apr 17, 2024

Conversation

cadedaniel
Copy link
Collaborator

@cadedaniel cadedaniel commented Apr 16, 2024 •
edited 

FAILED spec_decode/e2e/test_correctness.py::test_spec_decode_e2e_logical_flow[1-1-test_llm_kwargs0-per_test_common_llm_kwargs0-common_llm_kwargs0] - TypeError: Worker.__init__() missing 1 required positional argument: 'load_config'

FAILED spec_decode/e2e/test_correctness.py::test_spec_decode_e2e_logical_flow[1-1-test_llm_kwargs0-per_test_common_llm_kwargs1-common_llm_kwargs0] - TypeError: Worker.__init__() missing 1 required positional argument: 'load_config'

Caused by merge race between #4097 and #3894

@cadedaniel
Copy link
Collaborator Author

the AMD test agent is hung for some reason; I used this CI run to discover this https://buildkite.com/vllm/ci/builds/4916#_

@cadedaniel cadedaniel enabled auto-merge (squash) April 17, 2024 00:55
@cadedaniel cadedaniel merged commit d150e4f into vllm-project:main Apr 17, 2024
46 checks passed
@cadedaniel cadedaniel deleted the fix-main-ci branch April 17, 2024 01:03
robertgshaw2-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 21, 2024
@cadedaniel @robertgshaw2-neuralmagic
[Misc] [CI] Fix CI failure caught after merge (vllm-project#4126)
c2961e5
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request Apr 22, 2024
@cadedaniel @joerunde
[Misc] [CI] Fix CI failure caught after merge (vllm-project#4126)
7ee1206
robertgshaw2-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 26, 2024
@cadedaniel @robertgshaw2-neuralmagic
[Misc] [CI] Fix CI failure caught after merge (vllm-project#4126)
a84676e
@dtrifiro dtrifiro mentioned this pull request May 15, 2024
Merged
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request Jun 3, 2024
@cadedaniel @mawong-amd
[Misc] [CI] Fix CI failure caught after merge (vllm-project#4126)
b51d47a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cadedaniel @youkaichao