Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing docs and out of sync EngineArgs #4219

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Fix missing docs and out of sync EngineArgs #4219

merged 2 commits into from
Apr 20, 2024

Conversation

hmellor
Copy link
Collaborator

@hmellor hmellor commented Apr 20, 2024

Fixes missing developer documentation in:

Use sphinx-argparse for EngineArgs and AsyncEngineArgs documentation:

@hmellor hmellor requested a review from simon-mo April 20, 2024 02:15
@simon-mo simon-mo merged commit 682789d into vllm-project:main Apr 20, 2024
44 of 46 checks passed
@hmellor hmellor deleted the fix-docs branch April 20, 2024 08:54
@hmellor hmellor mentioned this pull request Apr 20, 2024
Merged
robertgshaw2-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 21, 2024
@hmellor @robertgshaw2-neuralmagic
Fix missing docs and out of sync EngineArgs (vllm-project#4219)
322cc2c 
Co-authored-by: Harry Mellor <hmellor@oxts.com>
ZackBradshaw pushed a commit to ZackBradshaw/vllm that referenced this pull request Apr 22, 2024
@hmellor @ZackBradshaw
Fix missing docs and out of sync EngineArgs (vllm-project#4219)
358762a 
Co-authored-by: Harry Mellor <hmellor@oxts.com>
ZackBradshaw pushed a commit to ZackBradshaw/vllm that referenced this pull request Apr 22, 2024
@hmellor @ZackBradshaw
Fix missing docs and out of sync EngineArgs (vllm-project#4219)
9828715 
Co-authored-by: Harry Mellor <hmellor@oxts.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Apr 25, 2024
@hmellor
Fix missing docs and out of sync EngineArgs (vllm-project#4219)
2f6c582 
Co-authored-by: Harry Mellor <hmellor@oxts.com>
robertgshaw2-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 26, 2024
@hmellor @robertgshaw2-neuralmagic
Fix missing docs and out of sync EngineArgs (vllm-project#4219)
dc1d3f7 
Co-authored-by: Harry Mellor <hmellor@oxts.com>
@hmellor hmellor restored the fix-docs branch April 29, 2024 09:41
alexeykondrat pushed a commit to alexeykondrat/ci-vllm that referenced this pull request May 1, 2024
@hmellor @alexeykondrat
Fix missing docs and out of sync EngineArgs (vllm-project#4219)
3783064 
Co-authored-by: Harry Mellor <hmellor@oxts.com>
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request May 7, 2024
@hmellor @joerunde
Fix missing docs and out of sync EngineArgs (vllm-project#4219)
a030b80 
Co-authored-by: Harry Mellor <hmellor@oxts.com>
@dtrifiro dtrifiro mentioned this pull request May 15, 2024
Merged
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request Jun 3, 2024
@hmellor @mawong-amd
Fix missing docs and out of sync EngineArgs (vllm-project#4219)
ed7ab48 
Co-authored-by: Harry Mellor <hmellor@oxts.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Doc]: Engine arguments of lora are not shown in VLLM docs on homepage
2 participants
@hmellor @simon-mo