Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add doc for running vLLM on the cloud #426

Merged
merged 8 commits into from
Jul 16, 2023

Conversation

Michaelvll
Copy link
Contributor

No description provided.

Copy link
Collaborator

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Left some comments.

docs/source/serving/run_on_cloud.rst Outdated Show resolved Hide resolved
docs/source/index.rst Outdated Show resolved Hide resolved
docs/source/serving/run_on_cloud.rst Outdated Show resolved Hide resolved
python -u -m vllm.entrypoints.api_server \
--model $MODEL_NAME \
--tensor-parallel-size $SKYPILOT_NUM_GPUS_PER_NODE \
--tokenizer hf-internal-testing/llama-tokenizer 2>&1 | tee api_server.log &
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make tokenizer also an envvar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Changed. Thanks!

conda activate vllm
echo 'Starting vllm api server...'
python -u -m vllm.entrypoints.api_server \
--model $MODEL_NAME \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we specify $MODEL_NAME?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is defined in envs section above. : )

Michaelvll and others added 4 commits July 12, 2023 14:33
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
Copy link
Collaborator

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you rename run_on_cloud.rst to run_on_sky.rst before we merge? @Michaelvll

@Michaelvll
Copy link
Contributor Author

Michaelvll commented Jul 14, 2023

Oops, sorry for missing it! Fixed the filename. I also changed the title to Running on clouds with SkyPilot. Otherwise, the table content will be in two lines. Wdyt?

Tested:

  • make html; cd build; python -m http.server
image

vs

image

@WoosukKwon
Copy link
Collaborator

@Michaelvll @zhuohan123 Sorry for the late response, but why don't we use a single GPU and a smaller model for the example?

@Michaelvll
Copy link
Contributor Author

@WoosukKwon That sounds good to me. Do you think single A100 with LLaMA-13b work?

@zhuohan123
Copy link
Collaborator

@WoosukKwon That sounds good to me. Do you think single A100 with LLaMA-13b work?

This should be great!

@Michaelvll
Copy link
Contributor Author

Done. PTAL @WoosukKwon @zhuohan123

@zhuohan123 zhuohan123 merged commit 58df288 into vllm-project:main Jul 16, 2023
2 checks passed
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants