[Bugfix][Model] Refactor OLMo model to support new HF format in transformers 4.40.0 #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosukKwon
approved these changes
Apr 24, 2024
|
Thanks @Isotr0py -- I was getting blocked by this on something fun! |
|
FYI @WoosukKwon and @Isotr0py -- I think there's a bug in this? I just tried to run the code and I get this error on how the classes are registered. Was with this model https://huggingface.co/allenai/OLMo-1.7-7B-hf, and another "being trained" UPDATE: Resolved |
|
@natolambert Could you share your model name (or the HF repo name)? The architecture should be |
|
EDIT: re-running it, maybe I had cached weights. Yup it works! @WoosukKwon was just adding it via edit: https://huggingface.co/allenai/OLMo-1.7-7B-hf |
|
There's a separate issue, but I think this is specific to our unreleased model (it at least starts the loading process). I'll investigate when it's a higher priority. |
|
We had typos in the architecture field of our HF |
|
@Isotr0py The model outputs gibberish: Could you take a look? |
|
@WoosukKwon Oops, I forgot to remove original lm_head code which broke the model lm_head without
|
|
@Isotr0py Thanks for the fix! It works now! |
|
@natolambert Does your internal model have the same architecture as OLMo? If so, could you try again the updated |
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Apr 26, 2024
…formers 4.40.0 (vllm-project#4324) Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
|
@WoosukKwon nope, but I probably won't look into why until closer to release, unless you've seen stuff like this before |
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 7, 2024
…formers 4.40.0 (vllm-project#4324) Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
mawong-amd
pushed a commit
to ROCm/vllm
that referenced
this pull request
Jun 3, 2024
…formers 4.40.0 (vllm-project#4324) Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FILL IN THE PR DESCRIPTION HERE
FIX #4310
This PR will add support for OLMo models in HF format (OLMo-1B-hf and OLMo-1.7-7B-hf etc)
Note that support for OLMo model in original format (OLMo-1B and OLMo-7B etc) will be deprecated, since we remove
hf_olmofrom dependency.BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Model]for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]For changes on the vLLM frontend (e.g., OpenAI API server,LLMclass, etc.)[Kernel]for changes affecting CUDA kernels or other compute kernels.[Core]for changes in the core vLLM logic (e.g.,LLMEngine,AsyncLLMEngine,Scheduler, etc.)[Hardware][Vendor]for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.shto format your code.docs/source/if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-requiredand might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-requiredlabel on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!